D5504: Introduce a HasLauncher data role.
Eike Hein
noreply at phabricator.kde.org
Wed Apr 19 11:05:44 UTC 2017
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This is implemented by TasksModel and allows clients to reliably
query whether a row has an associated launcher. Useful for things
like Pin/Unpin action state or layout decisions.
Previously clients would have to reimplement something like
TaskTools::appsMatch on top of the model, which we absolutely do
not want to do - there should only be one copy of the app matching
logic for consistency's sake. In practice clients would do things
like fetch LauncherUrl and run it by launcherPosition(), which
omits appsMatch's AppId comparision, as an example of such unwated
drift. This approach also avoids the large performance overhead
involved.
The role is not implemented by the single-type or munging tasks
models as it has no use there.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5504
AFFECTED FILES
libtaskmanager/abstracttasksmodel.h
libtaskmanager/tasksmodel.cpp
To: hein, #plasma, davidedmundson
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170419/8901c288/attachment.html>
More information about the Plasma-devel
mailing list