D5478: Fix crash in JSON traversal in Bing potd provider

David Rosca noreply at phabricator.kde.org
Sun Apr 16 15:45:54 UTC 2017


drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QJsonArray::operator[] returns QJsonValueRef which seems to crash
  when trying to convert to object.
  Using QJsonArray::at() instead which returns QJsonValue fixes the crash.
  
  BUG: 378590

TEST PLAN
  No longer crashes

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5478

AFFECTED FILES
  dataengines/potd/bingprovider.cpp

To: drosca, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170416/b811ba81/attachment.html>


More information about the Plasma-devel mailing list