D5471: https://bugs.kde.org/show_bug.cgi?id=377994

[Luigi Toscano]

ltoscano added a comment.


  I can't comment on the content of the patch, but I have a comment on the titles and the summary.
  
  The content of title+summary+test plan will become the git commit message, so I would:
  
  - change the title in a small summary of the change
  - in the body of the summary, no need to write "Resolves https://bugs.kde.org/show_bug.cgi?id=377994.", but simply add a line with:
  
  BUG: 377994
  
  which will do the magic when/if the commit is pushed.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D5471

To: ngraham, #plasma
Cc: ltoscano, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170416/72381cd8/attachment.html>