D5471: https://bugs.kde.org/show_bug.cgi?id=377994

[Nathaniel Graham]

ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Makes `/usr/bin/plasmashell --version` the canonical source of truth for the Plasma version. Resolves https://bugs.kde.org/show_bug.cgi?id=377994.

TEST PLAN
  Verified original problem by changing the value of X-KDE-PluginInfo-Version in  /usr/share/xsessions/plasma5.desktop and seeing that kinfocenter displays the new (incorrect) value.
  
  `make test`: passed
  
  Verified changes by deploying rebuilt /usr/lib64/qt5/plugins/kcm_about_distro.so file and seeing that kinfoCenter does not display the incorrect value in /usr/share/xsessions/plasma5.desktop, correctly using the value from `/usr/local/bin/plasmashell --version` instead.
  
  Replaced `/usr/local/bin/plasmashell` with a shell script that displays a different value and verified that the different value is displayed in kinfocenter
  
  Replaced `/usr/local/bin/plasmashell` with a shell script that displays a different value that does not follow the correct format or exits with a nonzero status and verified that the output is not displayed in kinfocenter and that it correctly falls back to reading the value from the distro-provided .desktop file.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D5471

AFFECTED FILES
  Modules/about-distro/src/Module.cpp

To: ngraham
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170416/69d97c22/attachment.html>