D5446: Implement support for selected mime type filters
noreply at phabricator.kde.org
Sat Apr 15 09:07:04 UTC 2017
dfaure added inline comments.
> elvisangelaccio wrote in kfiledialog_unittest.cpp:116
> No, selectedMimeTypeFilter() is only in 5.9 so that wouldn't compile
Oh I see. The QCOMPARE is just so that a failure happens. Pretty pointless, it's not testing anything from Qt. I would just remove the whole #else block.
The point of QEXPECT_FAIL is to either mark a TODO (but you fixed it already) or detect unexpected passes, which can't happen here ;-)
R135 Integration for Qt applications in Plasma
To: elvisangelaccio, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Plasma-devel