D5446: Implement support for selected mime type filters
noreply at phabricator.kde.org
Sat Apr 15 08:40:42 UTC 2017
elvisangelaccio added inline comments.
> dfaure wrote in kfiledialog_unittest.cpp:84
> Why use QMimeDatabase, just to then use name()? You could just put "text/x-chdr" in the data row, no?
Leftover from the previous patch, yes doesn't make sense now.
> dfaure wrote in kfiledialog_unittest.cpp:116
> Surely you mean QCOMPARE(dialog.selectedMimeTypeFilter(), QString())
No, selectedMimeTypeFilter() is only in 5.9 so that wouldn't compile
> dfaure wrote in qfiledialogtest.cpp:116
> this code looks ok to me, but it will hit the above assert when the -mimeTypeFilter option is absent, no?
Good catch, I'll drop the assert then.
R135 Integration for Qt applications in Plasma
To: elvisangelaccio, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Plasma-devel