D5446: Implement support for selected mime type filters
Elvis Angelaccio
noreply at phabricator.kde.org
Fri Apr 14 08:17:49 UTC 2017
elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QFileDialog in Qt 5.9 has better support for mimetype filters and
introduces the QFileDialog::selectedMimeTypeFilter() method [1].
This change implements the required functions on the Plasma side. We
cannot depend on Qt 5.9 yet, so the unit test will have an expected
failure if we are building against Qt < 5.9.
The manual test is also expanded.
[1]: http://code.qt.io/cgit/qt/qtbase.git/commit/?h=5.9&id=34f82b8abcb279542b6350e70609c549e39caafb
TEST PLAN
New unit tests pass when building against Qt >= 5.9.
Manual test also works as expected.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5446
AFFECTED FILES
autotests/kfiledialog_unittest.cpp
src/platformtheme/kdeplatformfiledialogbase_p.h
src/platformtheme/kdeplatformfiledialoghelper.cpp
src/platformtheme/kdeplatformfiledialoghelper.h
src/platformtheme/kdirselectdialog.cpp
src/platformtheme/kdirselectdialog_p.h
tests/qfiledialogtest.cpp
To: elvisangelaccio, #plasma, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170414/9ac9f149/attachment.html>
More information about the Plasma-devel
mailing list