D5424: [Notifications] Introduce "settings" action
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Apr 13 10:09:19 UTC 2017
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We've been having the configure button on notifications for a long time but so far it would only ever invoke KNotification configuration UI with no way for an application to provide its own, more versatile or extensive, UI.
When an action named "settings" is present in the notification the "configure" button will instead invoke this action.
TEST PLAN
Before:
F3677860: Screenshot_20170413_113924.png <https://phabricator.kde.org/F3677860>
After: (don't mind the changed text, I wanted to text how Chrome handles line breaks in its notifications)
F3677861: Screenshot_20170413_120654.png <https://phabricator.kde.org/F3677861>
Yes, this seems proprietary to Chrome which sends this along for its soon-to-be-released native notifications (above screenshot is from Chrome 59 with native notifications flag enabled) *but* I have wanted to have something like this for a long time and it's a good opportunity to introduce a de-facto standard for that now. I'll look into adding support for that in KNotifications, similar to the default action that was recently added.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5424
AFFECTED FILES
applets/notifications/package/contents/ui/NotificationDelegate.qml
applets/notifications/package/contents/ui/NotificationItem.qml
applets/notifications/package/contents/ui/NotificationPopup.qml
applets/notifications/package/contents/ui/Notifications.qml
To: broulik, #plasma, #vdg
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170413/41d3a0bd/attachment-0001.html>
More information about the Plasma-devel
mailing list