D5416: Polish ItemViewHeader, solve binding loops
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Wed Apr 12 16:32:04 UTC 2017
apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
Don't assume "page" in the namespace of ItemViewHeader, use view instead
which we have and symbolizes the same.
Don't change the implicitHeight when contentY is < 0.
Make page property readonly. Nobody is accessing it and it's private
When there's an image, don't wait to have the image to resize the header,
it makes the whole UI change without much sense as it should be fast.
Properly access the page property by name of the object, rather than having
QML go through the object tree. It failed to find the property sometimes.
Tests still pass, I don't get tons of warnings on Discover
To: apol, #kirigami, leinir, mart
Cc: plasma-devel, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Plasma-devel