D5402: always close the downloaded file after downloading
Marco Martin
noreply at phabricator.kde.org
Tue Apr 11 18:04:37 UTC 2017
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
sometimes the downloaded file isn't correctly flushed to
disk, causing corrupted zip files, especially if they come
from github that does a redirect. Unconditionally closing it
fixes the problem
TEST PLAN
downloaded the unity8 gtk3 theme that comes from github and is fine,
other files coming directly from store.kde.org are fine as well
REPOSITORY
R304 KNewStuff
BRANCH
phab/closeFile
REVISION DETAIL
https://phabricator.kde.org/D5402
AFFECTED FILES
src/core/jobs/httpworker.cpp
To: mart, #plasma, leinir, bshah
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170411/35f5010b/attachment.html>
More information about the Plasma-devel
mailing list