D5330: [QDBusMenuBar] Don't wait for (un)register call to finish

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> qdbusmenubar.cpp:169
> +        qDebug() << "Register finished" << watcher->isError() << watcher->error().name();
> +
> +        if (watcher->isError()) {

you leak this watcher

> qdbusmenubar.cpp:193
> +                         qUtf8Printable(watcher->error().name()), qUtf8Printable(watcher->error().message()));
> +                QDBusConnection::sessionBus().unregisterObject(m_objectPath);
> +            }

I don't understand why this is also here. You'll have always do line 199 first.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5330

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170410/289933f5/attachment-0001.html>