D5355: Fix query for available modules

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Apr 9 22:11:41 UTC 2017


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.cpp:62
> +    // We need the exist calls because otherwise the trader language aborts if the property doesn't exist and the second part of the or is not evaluated
> +    const KService::List services = KServiceTypeTrader::self()->query( "KCModule", "(exist [X-KDE-System-Settings-Parent-Category] and [X-KDE-System-Settings-Parent-Category] != '') or (exist [X-KDE-ParentApp] and [X-KDE-ParentApp] == 'kinfocenter')" );
>      for( KService::List::const_iterator it = services.constBegin(); it != services.constEnd(); ++it) {

Use QStringLiteral()?

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D5355

To: aacid, apol
Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170409/a3d8eb75/attachment.html>


More information about the Plasma-devel mailing list