D5144: Change the volume icon/mute button into a ToolButton

[David Rosca]

drosca accepted this revision.
drosca added a comment.
This revision is now accepted and ready to land.


  > My theory is that clicking the button will change the ToolButton's svg, which probably causes the naturalHeight to be set, causing the ColumnLayout to recalculate the height of the rows. Whatever is loading wrong at initialization is corrected, causes the reflow, which makes the text shift.
  
  No, it's a bug in PlasmaComponents.Label, it sets:
  
    height: Math.round(Math.max(paintedHeight, theme.mSize(theme.defaultFont).height*1.6))
  
  If you do `height: paintedHeight` in our code, the issue is fixed.
  
  > Should I go ahead and commit this?
  
  Yes, thanks.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: mart, subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170408/dc21f972/attachment.html>