D4806: [greeter] Send the auth result through the server instead return value
noreply at phabricator.kde.org
Fri Apr 7 15:51:32 UTC 2017
subdiff accepted this revision.
subdiff added a comment.
This revision is now accepted and ready to land.
Tested on X and Wayland.
> subdiff wrote in kcheckpass.c:263
> This line (and `GSendArr(len, prompt)` above) writes (in case of shadow auth 0) to the socket, which should lead to `reapVerify()` being called and the socket being closed before you can read in `ConvPutAuthSucceeded*` after `Authenticate(..)` finished.
I tested it with debug lines, and it works as intended. I assume handleVerify() isn't called a second time, because the fd wasn't written on in between by the greeter yet.
To: graesslin, #plasma, subdiff
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Plasma-devel