D4806: [greeter] Send the auth result through the server instead return value

[Roman Gilg]

subdiff accepted this revision.
subdiff added a comment.
This revision is now accepted and ready to land.


  Tested on X and Wayland.

INLINE COMMENTS

> subdiff wrote in kcheckpass.c:263
> This line (and `GSendArr(len, prompt)` above) writes (in case of shadow auth 0) to the socket, which should lead to `reapVerify()` being called and the socket being closed before you can read in `ConvPutAuthSucceeded*` after `Authenticate(..)` finished.

I tested it with debug lines, and it works as intended. I assume handleVerify() isn't called a second time, because the fd wasn't written on in between by the greeter yet.

REPOSITORY
  R133 KScreenLocker

BRANCH
  auth-result-through-server

REVISION DETAIL
  https://phabricator.kde.org/D4806

To: graesslin, #plasma, subdiff
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170407/4c13e1bb/attachment.html>