D5166: introduce ApplicationItem

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Tue Apr 4 09:41:45 UTC 2017


leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  i am inclined to ship this - there are the following couple of things which do show up, but the item works as expected anyway, and i now have a version of Calligra Gemini using Kirigami for a large part of its UI (there are details to be sorted as yet, including a not inconsiderable amount of UX reworking because of the old non-Kirigami-esque workflow design created by Cohere back in the day, but that is not caused by Kirigami, of course, and in particular not this item - so for the parts which are Kirigami-based now, it works :) )
  
  file:///usr/share/calligragemini/qml/WelcomePage.qml:35:19: QML GlobalDrawer: cannot find any window to open popup in.
  file:///usr/lib64/qt5/qml/org/kde/kirigami.2/AbstractApplicationItem.qml:306: TypeError: Cannot read property of null
  file:///usr/lib64/qt5/qml/org/kde/kirigami.2/AbstractApplicationItem.qml:105: TypeError: Cannot read property 'drawerOpen' of null

REPOSITORY
  R169 Kirigami

BRANCH
  phab/ApplicationItemwq!

REVISION DETAIL
  https://phabricator.kde.org/D5166

To: mart, #kirigami, leinir, apol
Cc: plasma-devel, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170404/8b033dfb/attachment.html>


More information about the Plasma-devel mailing list