Review Request 129065: Fix frameworks compilation with Qt < 5.6

David Edmundson david at davidedmundson.co.uk
Thu Sep 29 23:50:13 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 11:50 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
in earlier Qt.

This shouldn't have any behavioural effect.


Diffs
-----

  src/declarativeimports/core/windowthumbnail.cpp 0453c092f7a7144f04fdacc81b031e8c352fa23b 

Diff: https://git.reviewboard.kde.org/r/129065/diff/


Testing (updated)
-------

Ran on my nvidia machine and moused over the taskbar.

I got thumbnails as expected, but also Nvidia-settings shows "user dedicated memory" remaining constant


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160929/b09de25c/attachment.html>


More information about the Plasma-devel mailing list