[Differential] [Commented On] D2872: use KPluginSelector to enable runners

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> kcm.cpp:47
>      : KCModule(parent, args)
> -    , m_config(QStringLiteral("krunnerrc"))
> -    , m_configGroup(m_config.group("PlasmaRunnerManager"))
> +    , m_config("krunnerrc")
>  {

Are you even using that still? All I see is a KSharedConfig::openConfig in load

> kcm.cpp:76
>  
> -        if (!runners.isEmpty()) {
> -            const QRect rect = m_listWidget->visualItemRect(item);
> -            m_configButton->move(QPoint(rect.right(), rect.center().y()) - QPoint(m_configButton->width(), m_configButton->height()/2));
> -            m_configButton->setVisible(true);
> -            m_configButton->setProperty("runners", QVariant::fromValue(runners));
> -        } else {
> -            m_configButton->setVisible(false);
> -        }
> -    });
> +    //overload, can't use the new syntax
> +    connect(m_pluginSelector, SIGNAL(changed(bool)),

Sure you can, if you cast :)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  phab/kpluginselector

REVISION DETAIL
  https://phabricator.kde.org/D2872

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160929/5eb21d62/attachment-0001.html>