Review Request 129058: [corona] Sync config immidiately when it's dirty

[Marco Martin]

> On Sept. 28, 2016, 10:12 a.m., Marco Martin wrote:
> > all thisdoes is causing more disk access, making things slower
> 
> Anthony Fieroni wrote:
>     More disk access, maybe, but slower, how can be?
> 
> Aleix Pol Gonzalez wrote:
>     Why more disk access?
>     At least this won't be emitting configChanged if it was dirty and was a no-op sync.
> 
> David Edmundson wrote:
>     because there's more disk access.
>     
>     Turning this question around: how can yours be faster? - nothing is blocked waiting on the file to be written - so making that happen sooner won't speed anything up
> 
> Anthony Fieroni wrote:
>     Yes it is. Waiting 10 sec is never be faster. Even i wait more than 20 sec because timer is scheduled twice. On SSD, i have boot time 3 sec, KDE splash > 20 sec.
> 
> David Edmundson wrote:
>     But KSplash is not waiting for this timer to finish. Making that comment completely unrelated.
>     
>     The bootup starts, the bootup finishes - later this timer causes us to save some things.
>     
>     Nothing is waiting for this save to happen - so nothing will be faster if you make it happen earlier.
> 
> Marco Martin wrote:
>     it's not waiting on this timer in order to start
> 
> Anthony Fieroni wrote:
>     Still can't find who to blame for this slow starting?

mostly, creating qml objects


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129058/#review99612
-----------------------------------------------------------


On Sept. 28, 2016, 10:44 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129058/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 10:44 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This patch trys to minimize loading time of plasmashell, especially annoying waiting at splash screen.
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.h 07ad284 
>   src/plasma/corona.cpp 7ff64cd 
>   src/plasma/private/corona_p.h d556baf 
> 
> Diff: https://git.reviewboard.kde.org/r/129058/diff/
> 
> 
> Testing
> -------
> 
> Seems good but it may have downsides?
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160928/bc872a87/attachment.html>