Review Request 129058: [corona] Sync config immidiately when it's dirty

[David Edmundson]

> On Sept. 28, 2016, 10:12 a.m., Marco Martin wrote:
> > all thisdoes is causing more disk access, making things slower
> 
> Anthony Fieroni wrote:
>     More disk access, maybe, but slower, how can be?
> 
> Aleix Pol Gonzalez wrote:
>     Why more disk access?
>     At least this won't be emitting configChanged if it was dirty and was a no-op sync.

because there's more disk access.

Turning this question around: how can yours be faster? - nothing is blocked waiting on the file to be written - so making that happen sooner won't speed anything up


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129058/#review99612
-----------------------------------------------------------


On Sept. 28, 2016, 7:42 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129058/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 7:42 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This patch trys to minimize loading time of plasmashell, especially annoying waiting at splash screen.
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.cpp 7ff64cd 
> 
> Diff: https://git.reviewboard.kde.org/r/129058/diff/
> 
> 
> Testing
> -------
> 
> Seems good but it may have downsides?
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160928/6a2c0f9e/attachment.html>