Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129057/#review99608
-----------------------------------------------------------



still not ready, but big +1 as it was one of those old todo items that always get delayed for something being more urgent :)


src/plasma/applet.h (line 276)
<https://git.reviewboard.kde.org/r/129057/#comment66987>

    not in favor of not having an official way to access metadata from an instance, at least a new metadata() method should be introduced



src/plasma/applet.cpp (line 63)
<https://git.reviewboard.kde.org/r/129057/#comment66988>

    deprecate this as well?



src/plasma/applet.cpp (line 92)
<https://git.reviewboard.kde.org/r/129057/#comment66989>

    don't we have already a kpluginmetadata, built in the private ctor?



src/plasma/private/applet_p.h (line 49)
<https://git.reviewboard.kde.org/r/129057/#comment66990>

    since this is a private, it can even be removed, once its usage is cleared


- Marco Martin


On Sept. 28, 2016, 2:44 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129057/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 2:44 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> I've been looking into what we're actually doing nowadays when we learn about a plasmoid at boot. I realized that we were doing a bit of a roundabout and there's definitely shorter paths.
> 
> As far as I understood, what we're doing is:
> 
> 1. We list all plugins and construct their KPluginMetaData
> 2. We get the metadata file path and send it to corona, that will create a KService::Ptr and then construct a KPluginInfo from it.
> 3. KPluginInfo in turn parses the file again. Since recently KPluginInfo is parsing the files twice
> 3.1. using KPluginMetaData
> 3.2. using KDesktopFileParser
> 
> This patch, tries to simplify 2 and 3 into a KPluginMetaData construction call.
> 
> Furthermore, this will allow us eventually (in a separate iteration, and everything works according to the plan) to load plugins from metadata.json which would make it possible to get rid of the internal usage of the desktopfileparser within kcoreaddons. (With something like this https://paste.kde.org/pth9wmasc)
> 
> 
> Diffs
> -----
> 
>   src/plasma/applet.h 449f761 
>   src/plasma/applet.cpp 5e278dc 
>   src/plasma/private/applet_p.h c3fe1d2 
>   src/plasma/private/applet_p.cpp 0f37fe5 
>   src/plasma/scripting/appletscript.cpp 42c0395 
> 
> Diff: https://git.reviewboard.kde.org/r/129057/diff/
> 
> 
> Testing
> -------
> 
> My `plasmashell` starts beautifully, `CoronaTest::startupCompletion` doesn't for some reason I need to investigate further, but yes it's that late.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160928/dc5ed42e/attachment.html>