Review Request 128949: Add monitors for Linux memory infos dirty and writeback

Milian Wolff mail at milianw.de
Tue Sep 27 21:52:24 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/#review99601
-----------------------------------------------------------




ksysguardd/Linux/Memory.c (line 307)
<https://git.reviewboard.kde.org/r/128949/#comment66982>

    unrelated to the actual change set here, someone should cleanup this file to use Q_UNUSED instead of manually casting to void.


- Milian Wolff


On Sept. 22, 2016, 7:24 p.m., Pascal VITOUX wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128949/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 7:24 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> -------
> 
> Add monitors for Linux memory infos dirty and writeback
> 
> A usecase can be the monitoring of datas being written to a slow storage device like a USB mass storage before umounting and removing it.
> 
> 
> Diffs
> -----
> 
>   ksysguardd/Linux/Memory.h 2dbd6f2 
>   ksysguardd/Linux/Memory.c 1bc3ace 
> 
> Diff: https://git.reviewboard.kde.org/r/128949/diff/
> 
> 
> Testing
> -------
> 
> Works as expected in the ksysguard GUI application (system monitor).
> Also, I use it with a plasma widget almost everyday since several months without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160927/a3974331/attachment.html>


More information about the Plasma-devel mailing list