[Differential] [Commented On] D2874: Renamed userPrompt to userPromptComponent and add userListComponent id

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Concept is good, just need to do some code shuffling.

INLINE COMMENTS

> SessionManagementScreen.qml:60
>      property var userListCurrentModelData: userListView.currentItem === null ? [] : userListView.currentItem.m
> +    property bool showUserList: (userListModel.count && userListModel.disableAvatarsThreshold) ? userListModel.count <= userListModel.disableAvatarsThreshold : true
>  

this component is shared with the lockscreen and user switcher, you're going to be generating warnings there.

but from the other comment, we don't actually want this check here anyway.

> SessionManagementScreen.qml:69
>          id: userListView
> +        visible: showUserList
>          anchors {

Even when we're not showing the users we still want this view, as this view is set to a single entry model with the display name "Login as a different user"

we always want to show this.

> Login.qml:11
>  
> -    property bool showUsernamePrompt: false
> +    property bool showUsernamePrompt: !showUserList
>  

can you move the SDDM specific code here please.

> Main.qml:114
>                      enabled: true
> +                    visible: !userListComponent.showUsernamePrompt
>                  }

Why? If we're not showing the username prompt we won't be loading this component in the main view anyway.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2874

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160927/0083eb00/attachment-0001.html>