Review Request 129039: update startup and shutdown system settings group - others

Marco Martin notmart at gmail.com
Tue Sep 27 11:16:30 UTC 2016



> On Sept. 26, 2016, 10:06 p.m., David Edmundson wrote:
> > Weight changes - I think we can improve on that, and it's good that you are. +1
> > 
> > Moving KCMS around again - I'm massively against.
> > We've only just moved them round 24 months ago, and whilst it's fine to itterate and bug fix, this is just purely subjective changes with absolutely no rationale given.
> > Everyone has a different opinion where they should be, neither is more wrong, and neither is more right.  At which point moving causes more problems than it solves.
> 
> Andreas Kainz wrote:
>     If it's ok I will change the weight to the sorting as written. I don't add the Splash Screen and the Lock Screen to this subgroup.

agree with david. ok for the weight changes, let's not move things again


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129039/#review99553
-----------------------------------------------------------


On Sept. 26, 2016, 9:38 p.m., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129039/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 9:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> new startup and shutdown system setting group will look like this
> 
> Startup and Shutdown
> - Login Screen (SDDM)
> - Splash Screen
> - Autostart
> - Background Services
> - Lock Screen
> - Logout and Session
> 
> there are some patches to rearrange the existing kcm's.
> - https://git.reviewboard.kde.org/r/129037/
> - https://git.reviewboard.kde.org/r/129038/
> - https://git.reviewboard.kde.org/r/129039/
> 
> 
> Diffs
> -----
> 
>   kcms/autostart/autostart.desktop fdd7233 
>   kcms/kded/kcmkded.desktop 4d9aa28 
>   kcms/ksmserver/kcmsmserver.desktop c92a4b3 
>   kcms/ksplash/kcm_splashscreen.desktop b13691f 
> 
> Diff: https://git.reviewboard.kde.org/r/129039/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160927/1ad9ea03/attachment.html>


More information about the Plasma-devel mailing list