[Differential] [Request, 14 lines] D2865: Change component shown on selection changes

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Mon Sep 26 23:52:25 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ::activated depends on the mouse click behaviour - as double click
  starts a rename this led to the global shortcuts KCM being unusable with
  double click set.
  
  This patch follows the selection chaging - which is more semantically
  correct as we're not really activating an option in the left hand
  sidebar, merely selecting it to show the correct sub-options.
  
  It fixes keys up/down changing selection but also allows double click
  mouse settings to work.

TEST PLAN
  Ran.
  clicked once, got the correct sub-options.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2865

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160926/5ab58e1f/attachment.html>


More information about the Plasma-devel mailing list