[Differential] [Requested Changes To] D2846: Let kicker display executable items instead of empty buttons.

[hein (Eike Hein)]

hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> recentusagemodel.cpp:175
>  
> -    if (!service || !service->isApplication()) {
> +    if (!service || service->exec().isEmpty()) {
>          return QVariant();

Please check both the type and exec().

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2846

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, hein
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160924/a9d28a75/attachment.html>