Review Request 129009: [busy indicator] Limit animation loops

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129009/#review99496
-----------------------------------------------------------



I don't think we can try and "fix" application bugs in a library.

You don't know that someone doesn't want to try and loop indefinitely for some use case, and it just breaks as many things as it fixes.

- David Edmundson


On Sept. 24, 2016, 4:36 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129009/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 4:36 a.m.)
> 
> 
> Review request for Plasma, David Edmundson, David Rosca, and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> In some rar cases rotation animation enter endless loop, looks like client forgot to stop it in some corner cases. I try to limit it to 5 min, enough is enough.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml 0da6b77 
> 
> Diff: https://git.reviewboard.kde.org/r/129009/diff/
> 
> 
> Testing
> -------
> 
> Pass.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160924/e933bfd8/attachment.html>