[Differential] [Request, 20 lines] D2848: Fix binding loop in pager

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Fri Sep 23 21:39:18 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Previously on height changed rowHeight changed which changes columnWidth
  which in turn causes rowHeight to be re-evaluated - a loop.
  
  Moving it to a state machine solves that using a similar design pattern
  to the digital clock.

TEST PLAN
  Panel in horizontal looked normal
  Panel in vertical looked normal
  Moving panel back to horizontal still was fine

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2848

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160923/eca4635b/attachment.html>


More information about the Plasma-devel mailing list