Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

[David Rosca]

> On Sept. 22, 2016, 12:31 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmacomponents/qmenu.cpp, line 231
> > <https://git.reviewboard.kde.org/r/128999/diff/1/?file=477341#file477341line231>
> >
> >     if (!item) return;

Should be done also in other places.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/#review99412
-----------------------------------------------------------


On Sept. 23, 2016, 11:20 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128999/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qmenu.h 6eb4d89 
>   src/declarativeimports/plasmacomponents/qmenu.cpp b7037da 
> 
> Diff: https://git.reviewboard.kde.org/r/128999/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160923/bb3a97e3/attachment.html>