Review Request 117494: Proposed Patch for Bug 198661 - Add option to disable scroll on taskbar

[Olexa Bilaniuk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117494/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 8:42 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Bugs: 198661
    https://bugs.kde.org/show_bug.cgi?id=198661


Repository: plasma-desktop


Description
-------

Patch against plasma-desktop git master rev. ba6f2d7c054e7cdc1013c03a3f0821e8e328329b, fixing Bug 198661 - Add option to disable scroll on taskbar.

This patch adds a new checkbox under Task Manager Settings > General and a corresponding property called enableMouseScroll, with the default set to True (the current default). This property is checked on every onWheelMoved event, and only if true does it permit scrolling.


Diffs
-----

  applets/taskmanager/package/contents/config/main.xml 1a8fe8a 
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml 114f88a 
  applets/taskmanager/package/contents/ui/MouseHandler.qml 124e4c9 
  applets/taskmanager/package/contents/ui/Task.qml b6c3539 

Diff: https://git.reviewboard.kde.org/r/117494/diff/


Testing
-------

Don't know how to test. However, patch is trivially small; problems should be eyeballable.


Thanks,

Olexa Bilaniuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/a03e85c0/attachment.html>