Review Request 115431: Fix the numbers cut off problem in digital clock applet
David Edmundson
david at davidedmundson.co.uk
Thu Sep 22 20:40:25 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115431/#review99469
-----------------------------------------------------------
Closing as this review request is more than 2 years old.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On March 18, 2014, 12:56 p.m., Yichao Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115431/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 12:56 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 228902
> http://bugs.kde.org/show_bug.cgi?id=228902
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> For bug, see
> https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and
> https://bugs.kde.org/show_bug.cgi?id=228902
>
> The problem is that in original code, it always uses 23:59 to calculate the width of the text. However, in some font, AM is wider than PM, and 0 is wider than 2 and 5. That causes some fonts been cropped.
>
>
> Diffs
> -----
>
> plasma/generic/applets/digital-clock/clock.cpp f26e328
>
> Diff: https://git.reviewboard.kde.org/r/115431/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yichao Zhou
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/a2c605c7/attachment.html>
More information about the Plasma-devel
mailing list