Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer

David Edmundson david at davidedmundson.co.uk
Thu Sep 22 20:39:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116800/#review99466
-----------------------------------------------------------



Closing as this review request is more than 2 years old.

If it still applies to current Plasma please reopen this review request. Thanks

- David Edmundson


On April 24, 2014, 1:38 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116800/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 1:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> -------
> 
> The appletPath contains the path of the applet, if the user
> doesn't give a path then the refresh button of the plasmoidviewer will
> be hidden because we need the plasmoid path in order to execute
> `plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically
> so the user can refresh the plasmoid without having to install the plasmoid manually.
> 
> 
> Diffs
> -----
> 
>   plasmoidviewer/main.cpp 009acbb 
>   plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 8a125ea 
>   plasmoidviewer/view.h d997f15 
>   plasmoidviewer/view.cpp aa89145 
> 
> Diff: https://git.reviewboard.kde.org/r/116800/diff/
> 
> 
> Testing
> -------
> 
> 1. paths like ~/kf5/foo/plasmoid work
> 2. the plasmoid is being loaded even without the --appletPath
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/9acf0e34/attachment.html>


More information about the Plasma-devel mailing list