Review Request 117736: Plasmaboard: don't use m_keyboardSize for plasmoid size

David Edmundson david at davidedmundson.co.uk
Thu Sep 22 20:39:47 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117736/#review84690
-----------------------------------------------------------



Closing as this review request is more than 2 years old.

If it still applies to current Plasma please reopen this review request. Thanks

- David Edmundson


On April 24, 2014, 11:21 a.m., Sergei Lopatin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117736/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 11:21 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> m_keyboardSize calculates wrong. So if I add plasmaboard to panel from js code using plasma updates mechanism, the default size sets really wrong (like 400x1024).
> This patch simply returns fixed size for plasmoid in any case.
> 
> 
> Diffs
> -----
> 
>   applets/plasmaboard/widget.cpp 5628d63 
> 
> Diff: https://git.reviewboard.kde.org/r/117736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergei Lopatin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/6a4946de/attachment.html>


More information about the Plasma-devel mailing list