Review Request 116983: Fix the height of the buttonsbar

David Edmundson david at davidedmundson.co.uk
Thu Sep 22 20:37:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116983/#review99462
-----------------------------------------------------------



Closing as this review request is more than 2 years old.

If it still applies to current Plasma please reopen this review request. Thanks

- David Edmundson


On March 24, 2014, 10:26 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116983/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 10:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> -------
> 
> If I am not mistaken a regression has been introduced in plasmoidviewer.
> This patch solves the issue.
> 
> 
> Diffs
> -----
> 
>   plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 
> 
> Diff: https://git.reviewboard.kde.org/r/116983/diff/
> 
> 
> Testing
> -------
> 
> I have attached two images 1 without my patch and one with my patch
> 
> 
> File Attachments
> ----------------
> 
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png
> plasmoidviewer without margins
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/de8212c3/attachment.html>


More information about the Plasma-devel mailing list