Review Request 110504: Group tasks by activity

[José Millán Soto]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110504/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 8:35 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: kde-workspace


Description
-------

New grouping strategy was created to allow tasks to be grouped by activity.
If an item is available in multiple activities, it will only appear in one of the activities the task is available on (except if it's available on all activities).
GroupManager was modified so that whether items should be grouped just when the task bar is full or not is not only taken into account when grouping by program but also when grouping by activity.
Activity icons are not handled yet, so an icon from the first task which was on the group is used as the icon of the task group.


Diffs
-----

  libs/taskmanager/CMakeLists.txt 70fa791 
  libs/taskmanager/groupmanager.h ad4167a 
  libs/taskmanager/groupmanager.cpp 9ac15e7 
  libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION 
  libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION 
  plasma/desktop/applets/tasks/tasks.cpp dbbb0cb 

Diff: https://git.reviewboard.kde.org/r/110504/diff/


Testing
-------

Three activities were created (named "Activity 1", "Activity 2" and "Activity 3").
One instance of KDialog was assigned to Activity 1, two instances of KDialog were assigned to Activity 2, three instances of KDialog were assigned to Activity 3 and one instance of KDialog was assigned both to Activities 2 & 3.
The tasks applet was executed in plasma-windowed in all activities.
Screenshot 1 & 2 show the task manager in the situation described above. Screenshot 3 shows the same task manager after leaving only one instance of KDialog in each activity ("Only group when taskbar is full" enabled), and screenshot 4 shows the task manager when the tasks are the same that in screenshot 3 but "Only group when taskbar is full" is disabled.


File Attachments
----------------

Screenshot 1
  https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png
Screenshot 2
  https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png
Screenshot 3
  https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png
Screenshot 4
  https://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png


Thanks,

José Millán Soto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/820ad1f7/attachment.html>