Review Request 102291: Trigger installation of missing components when installing a package

David Edmundson david at davidedmundson.co.uk
Thu Sep 22 20:34:11 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102291/#review99450
-----------------------------------------------------------



Closing as this review request is more than 2 years old.

If it still applies to current Plasma please reopen this review request. Thanks

- David Edmundson


On Aug. 10, 2011, 10:10 p.m., Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/102291/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2011, 10:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This is another part of my GSoC 2011 work.
> 
> For script engines, the existing metadata (X-Plasma-API) is sufficient.
> 
> For data engines, we introduce a new metadata entry:
> X-Plasma-RequiredDataEngines. Third-party packages will have to add this entry
> to benefit from this feature at this time. Automatic support for scanning
> package source code on installation (at least for some languages) is planned,
> but the metadata entry is definitely the most efficient method.
> 
> 
> Diffs
> -----
> 
>   plasma/package.cpp 4c00d36 
>   plasma/packagemetadata.h b10f0e4 
>   plasma/packagemetadata.cpp 59163b2 
> 
> Diff: https://git.reviewboard.kde.org/r/102291/diff/
> 
> 
> Testing
> -------
> 
> Verified that it compiles without errors and that it successfully prompts for a missing Python script engine right after installing a Python widget (I used Veromix for my test) through KHNS (not only when actually using it) on Fedora 15. Also verified that there is no such prompt if plasma-scriptengine-python is already installed.
> 
> (The patch is against master (4.8), but applies without changes to the kdelibs 4.6.5 in Fedora 15, which is how I tested it.)
> 
> 
> Thanks,
> 
> Kevin Kofler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/42c37eac/attachment-0001.html>


More information about the Plasma-devel mailing list