Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

David Edmundson david at davidedmundson.co.uk
Thu Sep 22 20:31:25 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119990/#review99441
-----------------------------------------------------------



Closing as this review request is more than 2 years old.

If it still applies to current Plasma. Please reopen.

- David Edmundson


On Aug. 29, 2014, 1 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119990/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2014, 1 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> Since libksysguard probably aims to be a framework, the libraries should have respective names and includes should be installed to KF5_INCLUE_INSTALL_DIR. Solves conflicts with KDE 4.
> 
> 
> Diffs
> -----
> 
>   ksgrd/CMakeLists.txt 64ad24a 
>   lsofui/CMakeLists.txt 2b0c8ac 
>   processcore/CMakeLists.txt 31eee10 
>   processui/CMakeLists.txt 150e198 
>   signalplotter/CMakeLists.txt 67aa8bb 
> 
> Diff: https://git.reviewboard.kde.org/r/119990/diff/
> 
> 
> Testing
> -------
> 
> Builds, installs, libraries are called libKF5*.so, includes in /usr/include/KF5/KSysGuard/
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/2c7d78d5/attachment.html>


More information about the Plasma-devel mailing list