Review Request 126524: Fixed custom wallpaper being not respected by sddm.

Joshua Noack joshua.noack at gmail.com
Thu Sep 22 19:56:32 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 3:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
-------

Submitted with commit 50445f794b3142f29dcc043f3af83c549c694bcd by David Edmundson on behalf of Joshua Noack to branch Plasma/5.8.


Repository: sddm-kcm


Description
-------

For some reason sddm cannot handle absolute file paths to wallpapers
and also needs the wallpaper to be readable by others.

This is fixed by copying the wallpaper to the root directory of the
selected theme.

On save the sddmauthhelper copies the background from the absolute path
into the theme directory and sets the "background" key of the
theme.user.conf to the copied file. If previously a different background was
set it is removed beforehand.


Diffs
-----

  sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
  src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 

Diff: https://git.reviewboard.kde.org/r/126524/diff/


Testing
-------

Copies and removes backgrounds as intended.
The wallpaper is shown in sddm.


Thanks,

Joshua Noack

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/4d5ada38/attachment.html>


More information about the Plasma-devel mailing list