[Differential] [Request, 7 lines] D2839: make media frame start with random image if set to random

jnicolay (Joachim Nicolay) noreply at phabricator.kde.org
Thu Sep 22 16:57:41 UTC 2016


jnicolay created this revision.
jnicolay added a reviewer: Plasma.
jnicolay set the repository for this revision to rKDEPLASMAADDONS Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  On startup the media frame will always start with the same image, even if random is selected.
  
  The reason is that the images are added to the list of items one by one and if no item is currently showing one will be picked as soon as it's available. In that case, always the first one that's discovered.
  
  The fix skips to the next (now random) item after loading is done when set to random.

TEST PLAN
  1. put media frame on desktop
  2. add several images
  3. set to random
  4. restart plasma several times (killall plasmashell && kstart5 plasmashell)
  5. without patch: the media frame will always start with the same image
  6. with patch: a random image is choosen on every start

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D2839

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jnicolay, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160922/f68b5088/attachment.html>


More information about the Plasma-devel mailing list