Review Request 128996: Don't generate appstream files for components that are not in rdn
David Edmundson
david at davidedmundson.co.uk
Wed Sep 21 22:50:52 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128996/#review99399
-----------------------------------------------------------
+1
- David Edmundson
On Sept. 21, 2016, 10:41 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128996/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 10:41 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> Appstream will spit them out anyway, better do it early in the process and with a warning.
>
>
> Diffs
> -----
>
> KF5PackageMacros.cmake 7a12292
>
> Diff: https://git.reviewboard.kde.org/r/128996/diff/
>
>
> Testing
> -------
>
> Plasma Desktop doesn't generate information for offending components but also won't make the test fail.
>
> ```
> Appstream information won't be generated for kcm_splashscreen.
> Appstream information won't be generated for kcm_desktoptheme.
> Appstream information won't be generated for kcm_lookandfeel.
> ```
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160921/02060556/attachment.html>
More information about the Plasma-devel
mailing list