Review Request 128760: Fix crash on exit

[Peter Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/
-----------------------------------------------------------

(Updated Sept. 21, 2016, 12:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da Costa.


Changes
-------

Submitted with commit 23e54baa3cf1258b5d105c22609103d13868583f by Hugo Pereira Da Costa on behalf of Peter Wu to branch Plasma/5.7.


Bugs: 356940
    https://bugs.kde.org/show_bug.cgi?id=356940


Repository: breeze


Description
-------

Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.

This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.


Diffs
-----

  kstyle/breezestyleplugin.cpp 083100e 

Diff: https://git.reviewboard.kde.org/r/128760/diff/


Testing
-------

Ran the updated test.sh from "Testcase (ASAN) with normal QApplication::quit and exit()" from bug https://bugs.kde.org/show_bug.cgi?id=356940, no longer crashes. Tested with Qt 5.7.0.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160921/44ef80ed/attachment.html>