[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> sortedactivitiesmodel.cpp:197
>          bool initialized;
> -        KConfig plasmaConfig;
> +        KSharedConfig::Ptr plasmaConfig;
> +        QTimer updateTimer;

Now it's a sharedconfig (a *very* sensible change) - you don't even need to call  reparseConfiguration().

that means it's fairly cheap to call reload.

that means you don't need the timer.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160921/25da5cd8/attachment.html>