Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[Marco Martin]

> On Sept. 19, 2016, 9:52 p.m., Marco Martin wrote:
> > shell/scripting/panel.cpp, line 189
> > <https://git.reviewboard.kde.org/r/128950/diff/1/?file=477151#file477151line189>
> >
> >     this can't rely on the order of qGuiApp->screens, but should use screenpool in shellcorona, it's the only place where you can find a reliable mapping
> 
> Kamil Sołtysik wrote:
>     From what I understood from the code, I need first to match ID with a connector and then search for a screen with matching connector in qGuiApp->screens, right?

the function to phisically move the panel can only be in shellcorona (using m_screenPool, don't try to reimplement its logic).
and should be:

* if the panel view exists, discover the id using screenpool (qGuiApp->screens().indexOf is *not* the id)

* if it doesn't, write the lastScreen config entry in the panel config


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/#review99285
-----------------------------------------------------------


On Sept. 20, 2016, 2:25 p.m., Kamil Sołtysik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128950/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=363592
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As stated in doc here: https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels Panels should allow to be placed on selected screen by setting value of Panel::screen property. While looking at code I found out that this property is read-only in code. Patch changes that.
> 
> 
> Diffs
> -----
> 
>   shell/scripting/panel.h 0d70784 
>   shell/scripting/panel.cpp b9383df 
> 
> Diff: https://git.reviewboard.kde.org/r/128950/diff/
> 
> 
> Testing
> -------
> 
> Panel's position can now be changed by setting the property. Setting invalid value causes no response.
> 
> 
> File Attachments
> ----------------
> 
> plasma-workspace-2.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/20/bc1df578-8758-48e4-b2b2-a53792c803f8__plasma-workspace-2.patch
> 
> 
> Thanks,
> 
> Kamil Sołtysik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160921/12a7c047/attachment.html>