[Differential] [Request, 25 lines] D2823: [Device Notifier] Only ever pop up if device is visible in the list

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, sitter.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When a device notification arrives, such as "you can now safely unmount" or "failed to unmount" device notifier would unconditionally open showing an empty list.
  Since we now show device notifications only connected to the device they're about, it makes no sense to expand it for invisible devices. Applications where mounting or unmounting can fail for non-removable devices, like Dolphin, already show the error message within the UI anyway, making the popup redundant.
  
  BUG: 368894
  FIXED-IN: 5.8.0

TEST PLAN
  - plugged in USB key, still got popup
  - unmounted USB key from Dolphin, devicenotifier opened, telling me I could safely remove it now
  - tried to unmount / from Dolphin, got a "not authorized" error in Dolphin and no longer got an empty device notifier popup
  
  Didn't actually test the snappy usecase described in the bug report.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2823

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sitter
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160920/3ba9107d/attachment-0001.html>