[Differential] [Commented On] D2810: Fixed loading of the wallpapers in the activity switcher

[ivan (Ivan Čukić)]

ivan added inline comments.

INLINE COMMENTS

> mart wrote in switcherbackend.cpp:156
> could this have the implementation after the class definition, just for immediate readability?

Strange preference, but ok :)

> davidedmundson wrote in switcherbackend.cpp:181
> why not ScaledAndCached?

save=true, so it should be cached.

> 'save - if the image should be cached for later use'

> davidedmundson wrote in switcherbackend.cpp:191
> is this needed?
> 
> 1. KIO is set to scaled anyway, so will resize it.
> 2. the QML code can resize the image at an openGL level by setting an appropriate fillMode.
> 
> The above two will keep aspect ratio properly.

Probably not, will remove.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2810

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160920/02ed5fe8/attachment.html>