[Differential] [Commented On] D2817: better bookeeping of the config

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in systemtray.cpp:136
> Is this for the DBus activated case?

not only, actually this case is true for each startup after the first, during normal config restore. This is the branch always executed except when a previously unknown applet is added

> davidedmundson wrote in systemtray.cpp:154
> This reintroduces the NetworkManager restarting bug.
> 
> Applet exists, is still in applets() but now isn't marked as transient as you're not marking it as such.

don't know how to properly fix it without changes in p-f tough ( i could still call destroy() in case of mutable, tough when an applet goes away for dbus reasons, its config should actually not be removed (so shouldn't be transient)..

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2817

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160920/59fc5c31/attachment.html>