[Differential] [Changed Subscribers] D2817: better bookeeping of the config

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> systemtray.cpp:136
>  
> -    createApplet(task, QVariantList() << "org.kde.plasma:force-create");
> +    //known one, recycle the id to reuse old config
> +    if (m_knownPlugins.contains(task)) {

Is this for the DBus activated case?

> systemtray.cpp:154
> +            //the config the next time it's loaded, in case the user configured something here
> +            applet->deleteLater();
>          }

This reintroduces the NetworkManager restarting bug.

Applet exists, is still in applets() but now isn't marked as transient as you're not marking it as such.

> systemtray.cpp:381
>              if (!m_allowedPlasmoids.contains(task)) {
> -                applet->destroy();
> +                //in those cases we do delete the applet config completely
> +                //as they were explicitly disabled by the user

C++ applets can override cleanupAndDelete

You're skipping that. 
(not that any do)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2817

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160920/4c1dcc6e/attachment.html>