Review Request 128915: resize the view just after setting the containment

David Edmundson david at davidedmundson.co.uk
Thu Sep 15 11:02:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99202
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Sept. 15, 2016, 10:57 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 10:57 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so the view subclass can have the view resized to the proper size beforehand, removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160915/f32ee1d2/attachment.html>


More information about the Plasma-devel mailing list