[Differential] [Commented On] D2778: Expose the banner sourceSize

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  In https://phabricator.kde.org/D2778#51900, @mart wrote:
  
  > patch in general makes sense
  >
  > but are you sure svg doesn't export a soucesize? (svgs do have a size in pixels in their root layer and qtsvg supports it)
  
  
  Of course it does, but it's a size, here we're not interested in giving it a size, we just should make sure it fits the banner.
  We could set a 5000x3000 size, but then we'd be rendering it too big then scaling it down.
  
  If you ask me, we should just make Kirigami enforce the look of the banner (despite the developer adding a strictly vertical image), then this property wouldn't be required.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2778

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160915/cc8e57d8/attachment.html>