Review Request 128915: resize the view just after setting the containment

[Aleix Pol Gonzalez]

> On Sept. 15, 2016, 12:01 p.m., Aleix Pol Gonzalez wrote:
> > src/plasmaquick/containmentview.cpp, line 101
> > <https://git.reviewboard.kde.org/r/128915/diff/1/?file=476912#file476912line101>
> >
> >     Wouldn't it be better to pass the size with the incubation properties?
> 
> Marco Martin wrote:
>     hmm, you can't access it for the item that you load with setSource i think?

Yes, I looked into it and it would be possible but only to whoever constructs the object, as it's being incubated within the Containment.

It might be worth looking into though, as the values set there will be initialized before the properties are bound. Possibly it doesn't even make sense to have the item created before it has a view altogether.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128915/#review99192
-----------------------------------------------------------


On Sept. 15, 2016, 11:20 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128915/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> when the view is in SizeRootObjectToView mode, the root object is resized in the event handler, that is too late at startup.
> resize the root object right after having announced the new containment, so the view subclass can have the view resized to the proper size beforehand, removing an useless containment graphicsobject resize.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/containmentview.cpp 8517099 
> 
> Diff: https://git.reviewboard.kde.org/r/128915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160915/f77226ad/attachment-0001.html>