Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

[Raphael Kugelmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125416/
-----------------------------------------------------------

(Updated Sept. 15, 2016, 10:44 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 70e339f3d0d0aff16559f198ac4c6dc5f6c90111 by David Edmundson on behalf of Raphael Kugelmann to branch master.


Bugs: 328807
    https://bugs.kde.org/show_bug.cgi?id=328807


Repository: ksysguard


Description
-------

BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

https://bugs.kde.org/show_bug.cgi?id=328807

Two issues fixed:
- crash during removing a bar Sensor
- wrong Sensors is removed
- labels are not set as expected after removing a bar


Diffs
-----

  gui/SensorDisplayLib/BarGraph.cpp ecd6674ea4f66c3c061feb31c6a68e2e7abed885 
  gui/SensorDisplayLib/DancingBars.cpp 13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12 
  gui/SensorDisplayLib/DancingBarsSettings.h 27df0666db53621ecddb2e4763b26509103f7381 
  gui/SensorDisplayLib/DancingBarsSettings.cpp 6eb9c21b1670b028570e3826620b98e07eac266d 

Diff: https://git.reviewboard.kde.org/r/125416/diff/


Testing
-------

Tested
- no crash anymore
- the remaining sensors are the one as expected


Thanks,

Raphael Kugelmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160915/24c54a4c/attachment.html>